New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-fieldset): label, description, and feedback slots, deprecate label-size #598

Merged
merged 4 commits into from Jun 30, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Jun 30, 2017

Add named slot support for label, feedback, and description.

Deprecate label-size in favour of label-cols

Will help prevent confusion of size (being columns, not text size), as per issue #594

Addresses issue #597

[form-fieldset] label, description,a and feedback slots, deprecate la…
…bel-size

Add named slots for label, feedback, and description.

Deprecate label-size in favour of label-cols

@tmorehouse tmorehouse added this to the v0.18.0 milestone Jun 30, 2017

tmorehouse added some commits Jun 30, 2017

@tmorehouse tmorehouse requested review from pi0 and alexsasharegan Jun 30, 2017

@pi0

pi0 approved these changes Jun 30, 2017

@tmorehouse tmorehouse modified the milestones: v0.17.2, v0.18.0 Jun 30, 2017

@tmorehouse tmorehouse merged commit e253dae into master Jun 30, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-form-fieldset branch Jun 30, 2017

@tmorehouse tmorehouse modified the milestones: v0.18.0, v0.17.2 Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment