New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): live demo #602

Merged
merged 5 commits into from Jun 30, 2017

Conversation

Projects
None yet
4 participants
@pi0
Member

pi0 commented Jun 30, 2017

I've tried to move all examples from JSFiddle here. Please give your feedback :)

@pi0 pi0 requested review from tmorehouse, alexsasharegan and mosinve Jun 30, 2017

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jun 30, 2017

I should be able to git checkout, run docs-dev, and play with this myself, right?

@pi0

This comment has been minimized.

Member

pi0 commented Jun 30, 2017

@alexsasharegan Yep! :)

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jun 30, 2017

Maybe this sounds silly, but the double-click to edit note doesn't advertise this well enough. Maybe that could at least be bigger and bolder?

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

Looks cool! so can we do multiple examples per page too?

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jun 30, 2017

You beat me to the typos!

@pi0

This comment has been minimized.

Member

pi0 commented Jun 30, 2017

@alexsasharegan I've just copy-paste styles from vue.js docs :D Feel free making it bigger

@pi0

This comment has been minimized.

Member

pi0 commented Jun 30, 2017

@tmorehouse Yes. We also can use simpler syntax for inline examples.(Like badges docs without template and script!)

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jun 30, 2017

Would I edit directly in the /docs/nuxt/assets/css/styles.css? Or is that pulled from somewhere else?

@tmorehouse tmorehouse added this to the v0.17.2 milestone Jun 30, 2017

@pi0

This comment has been minimized.

Member

pi0 commented Jun 30, 2017

Yes we can edit that file

@tmorehouse

👍

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jun 30, 2017

I'm no designer, so feel free to smooth out the rough edges of my attempts to grab attention to the content-editable.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

Make it 400px font-size 😜

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

Once this is merged in, I could add/edit a few examples.

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jun 30, 2017

Just curious, does this playground pose any security threat to the host? The more popular the repo gets, the more that could be a potential concern.

@pi0

This comment has been minimized.

Member

pi0 commented Jun 30, 2017

I hope it can't. <script> part should be evalouated if CURRENT USER double clicks and edits that section. So if such code creates security threat how JSFiddle works more secure?

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

jsFiddle uses sandboxed iframes I think. But I think that is to prevent XSS when jsfiddle are embedded.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

I suppose it would be the same as if someone used dev tools console to add their own <script> tags

@pi0 pi0 merged commit 843057e into master Jun 30, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@pi0 pi0 modified the milestones: v0.18.0, v0.17.2 Jun 30, 2017

@pi0

This comment has been minimized.

Member

pi0 commented Jun 30, 2017

(It is a feat, so should be added for minor bump)

@tmorehouse tmorehouse modified the milestones: v0.17.2, v0.18.0 Jun 30, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

So ar we going to skip[ 0.17.2 and go straight to 0.18.0?

@pi0

This comment has been minimized.

Member

pi0 commented Jun 30, 2017

I think we should :)

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

OK cool... 👍

@pi0

This comment has been minimized.

Member

pi0 commented Jun 30, 2017

Hope bootstrap4 rcs come sooner before we reach 0.99.0 :D

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

Are there any other things we want to put in vor v0.18.0?

@pi0

This comment has been minimized.

Member

pi0 commented Jun 30, 2017

@tmorehouse You decide. We have some open PRs do you think can be landed in 0.18.0 ?

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

@alexsasharegan has a doc update for async modal cancelling, but no PR yet... that could wait until later.

I was going to add aria-invalid="true" support on some of the form-inputs, but there is no big rush for that.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jun 30, 2017

And also moving some non-common props in the form mixin to the components (issue #542 )

But that can wait as well.. I'm kinda eager to see the new docs live :-)

@mosinve

This comment has been minimized.

Member

mosinve commented Jul 1, 2017

I have an error with multiple roots in componentdoc.vue

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 1, 2017

@mosinve is that on v0.18.0 or master?

@mosinve

This comment has been minimized.

Member

mosinve commented Jul 1, 2017

master

@mosinve

This comment has been minimized.

Member

mosinve commented Jul 1, 2017

i moved last b-card into root div and it works

@mosinve

This comment has been minimized.

Member

mosinve commented Jul 1, 2017

and there is a typo Vue.js docuementation

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 1, 2017

Yeah... I just moved that from componentdoc.vue over to _component.vue, which should fix the issue.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 1, 2017

There are a few typo's (troy-o's) in the docs.

@mosinve

This comment has been minimized.

Member

mosinve commented Jul 1, 2017

they should stay as easter eggs, or may be fixed?

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 1, 2017

Yeah, they should be fixed probably.

We could create a new temp branch for editing the docs.

@pi0 pi0 deleted the v-play branch Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment