New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdowns): Various optimizations for dropdown components #627

Merged
merged 55 commits into from Jul 4, 2017

Conversation

Projects
None yet
4 participants
@tmorehouse
Member

tmorehouse commented Jul 3, 2017

  • Deprecate slot text in favour of slot button-content(addresses issue #617)
  • Migrated data(), common props, methods & clickout into dropdown mixin
  • Removed prop link as setting variant="link" does the same thing
  • Removed undocumented <b-button-group-dropdown> in favour of using <b-dropdown>

tmorehouse added some commits Jul 3, 2017

[button-group-dropdown] Rename button text slot
Adds a new slot `button-content` which take precedence over deprecated `text` slot
[dropdown] Deprecate slot text in favour of slot button-content
Also removed link prop, as this can be provided via the variant prop
[dropdown mixin] Consolidate props & methods
Also moved split prop to components that support it
[button-group-dropdown] Consolidate methods and data to mixin
Move data, methods, and clickout to dropdown mixin
[nav-item-dropdown] Migrate data, methods, clickout to mixin
Migrated data, methods, and clickout to dropdown mixin
[dropdown] Migrate data, methods, id, clickout to dropdown mixin
Moved common features, mixins, props, & methods to dropdown mixin

tmorehouse added some commits Jul 4, 2017

[rollup-config.js] Add Object Assign support
Enables transpilation of object spread to `Object.assign`
[rollup.extra.config.js] Add object assign to Buble
Allows transpilation of object spread top `Object.assign`
@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jul 4, 2017

Yay! 😃 🎉 I love object spread!

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 4, 2017

Yay, it worked! 😃

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 4, 2017

@alexsasharegan once this is merged your link mixin stuff could take advantage of it 😄

But maybe after 0.18.0 comes out. 😛

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jul 4, 2017

I'm tinkering with a functional link component right now.
😃 Spread definitely helps!

@tmorehouse tmorehouse requested review from pi0 and mosinve Jul 4, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 4, 2017

This PR saves us, net, one line of code:
image

😝

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jul 4, 2017

#winning

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 4, 2017

Although some of that is new comments, and indent changes, and added documentation ;-)

@mosinve

mosinve approved these changes Jul 4, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 4, 2017

@alexsasharegan have you had a chance to look over the changes in this PR?

tmorehouse added some commits Jul 4, 2017

[button-group] Minor documentation update
Example heading format changes
@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jul 4, 2017

Is there a reason why the tests throw deprecation notices like it's the 4th of July? (which it almost is) Is this just how the tests were written?

image

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 4, 2017

Ah, each time the component is instantiated it will generate that warn.

@mosinve

This comment has been minimized.

Member

mosinve commented Jul 4, 2017

maybe rewrite tests to use actual prop instead deprecated?

Alex Regan
@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 4, 2017

Which test is using fom-fieldset?

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jul 4, 2017

Looks like the table test

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 4, 2017

OK, I'll create a separate PR to change that

@alexsasharegan

Put it through the ringer in the nuxt dev site. Fixed one method typo that was lighting up, but it looks good!

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 4, 2017

PR #630 fixes the fieldset deprecation warnings in the table tests.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 4, 2017

Those console deprecation warnings should be gone now (table tests)

@tmorehouse tmorehouse merged commit 56d29b0 into master Jul 4, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-dropdowns branch Jul 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment