New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-radio): isChecked to work with arrays & non-arrays. #629

Merged
merged 3 commits into from Jul 4, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Jul 4, 2017

Fix for issue #623

isChecked computed prop now tests for array (multiple checkboxes bound to same v-model) or non-array (single checkbox bound to v-model)

Added extra documentation as well

fix(form-radio): isChecked to work with arrays & non-arrays.
Fix for issue  #623

make isChecked computed prop check for array (multiple checks bound to same v-model) or non-array (single checkbox bound to v-model)

@tmorehouse tmorehouse added the Type: Bug label Jul 4, 2017

@tmorehouse tmorehouse added this to the v0.18.0 milestone Jul 4, 2017

@tmorehouse tmorehouse requested review from pi0 and alexsasharegan Jul 4, 2017

tmorehouse added some commits Jul 4, 2017

[form-checkbox] Documentation update
Multiple checkbox example
@pi0

pi0 approved these changes Jul 4, 2017

@tmorehouse tmorehouse merged commit 578d451 into master Jul 4, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-form-checkbox branch Jul 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment