-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(b-dropdown): add toggle-attrs
prop (closes #3694)
#6339
feat(b-dropdown): add toggle-attrs
prop (closes #3694)
#6339
Conversation
Add `toggle-attrs` prop to allow adding HTML attributes to the dropdown toggle
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/8fw84zizf |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a31f67f:
|
Codecov Report
@@ Coverage Diff @@
## dev #6339 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 299 299
Lines 10105 10105
Branches 2512 2512
=========================================
Hits 10105 10105
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
toggle-attrs
prop. fixes 3694toggle-attrs
prop (closes #3694)
Thanks @phegman! |
@jackmu95 Thanks for reviewing and making those stylistic changes! Bootstrap Vue is an impressively consistent codebase, makes it very enjoyable to work on! |
Describe the PR
Add
toggle-attrs
prop to allow adding HTML attributes to the dropdown toggle. This feature has been talked about here: #3694At GitLab we have a component library built on top of Bootstrap Vue and would like this feature so that we can add the
data-qa-selector
attribute to the dropdown toggle. We use this attribute exclusively for QA E2E specs. I could also see it being helpful for adding thedata-testid
attribute which is supported by Vue Testing Library. This prop could also be used for other user-facing attributes such asaria-*
attributes.Closes #3694.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: