New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs.vue): Fix link to edit setup doc #641

Merged
merged 3 commits into from Jul 5, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Jul 5, 2017

Fixes #639

"Edit this page" link broken for /docs/setup

Also when on '/docs/components/' links to erroneous /docs/components//README.md

fix(docs.vue): Fix link to edit setup
Fixes  #639

"Edit this page" link broken for /docs/setup

@tmorehouse tmorehouse requested a review from pi0 Jul 5, 2017

@pi0

This comment has been minimized.

Member

pi0 commented Jul 5, 2017

Should develop a more general solution :D BTW Would be nice for now :)

@pi0 pi0 merged commit 836db33 into master Jul 5, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 5, 2017

Yeah, this was a quick fix for now, but maybe adding a entra property in the site pages structure?

@pi0

This comment has been minimized.

Member

pi0 commented Jul 5, 2017

I'm planning to make better attached meta for page (jekeyll style) so we can define all meta on Markdowns too :)) Learning things day to day :))

@tmorehouse tmorehouse deleted the tmorehouse-docs-setup branch Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment