New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): transpiler friendly polyfills and methods #658

Merged
merged 50 commits into from Jul 8, 2017

Conversation

Projects
None yet
3 participants
@alexsasharegan
Contributor

alexsasharegan commented Jul 6, 2017

This PR needs to wait for @mosinve's PR #656 so changes can be merged by hand.

  • merged

Update

There's a little bit of formatting junk in here, but this is mainly a move to consolidating some modern language features into central modules. This allows for polyfilling and minification optimization.

Introduces:

  • Object.assign polyfill
  • Array.from polyfill
  • Array.isArray polyfill (existed previously)

Alex Regan added some commits Apr 29, 2017

Alex Regan
Alex Regan
Merge branch 'master' of https://github.com/bootstrap-vue/bootstrap-vue
# Conflicts:
#	lib/components/form-fieldset.vue
Alex Regan
Alex Regan
Merge branch 'master' of https://github.com/bootstrap-vue/bootstrap-vue
# Conflicts:
#	lib/components/form-input.vue
Alex Regan
Merge branch 'master' of https://github.com/bootstrap-vue/bootstrap-vue
# Conflicts:
#	lib/mixins/listen-on-root.js

@alexsasharegan alexsasharegan changed the title from [WIP] feat(utils): transpiler friendly polyfills and methods to feat(utils): transpiler friendly polyfills and methods Jul 7, 2017

@alexsasharegan alexsasharegan requested review from tmorehouse, pi0 and mosinve Jul 7, 2017

@tmorehouse tmorehouse added this to the v0.19.0 milestone Jul 7, 2017

@@ -76,14 +76,15 @@
</template>
<script>
import {warn} from '../utils';
import { warn } from '../utils';
import { keys } from '../utils/object';

This comment has been minimized.

@mosinve

mosinve Jul 7, 2017

Member

interesting, if we can do this like import { object.keys as keys } from '../utils';

This comment has been minimized.

@mosinve

mosinve Jul 7, 2017

Member

Guess not...

This comment has been minimized.

@tmorehouse

tmorehouse Jul 7, 2017

Member

What about nested destructuring?

import { object: { keys} } from '../utils';

This comment has been minimized.

@tmorehouse

tmorehouse Jul 7, 2017

Member

Although I think you can only do one nested destructure (but as many sub properties as you want)

This comment has been minimized.

@alexsasharegan

alexsasharegan Jul 7, 2017

Contributor

Es2015 imports are definitely not the same as object destructuring. I've been down that road. It stinks!

This comment has been minimized.

@alexsasharegan

alexsasharegan Jul 7, 2017

Contributor

@tmorehouse, the destructuring is just the named export access syntax. Looks like a duck, walks like a duck, but it's a module.

This comment has been minimized.

@tmorehouse

tmorehouse Jul 7, 2017

Member

Booo

This comment has been minimized.

@alexsasharegan

alexsasharegan Jul 7, 2017

Contributor

Couldn't agree more 😞

import linkMixin from './link';
import listenOnRootMixin from './listen-on-root';
import popoverMixin from './popover';
import clickOutMixin from "./clickout"

This comment has been minimized.

@mosinve

mosinve Jul 7, 2017

Member

At upper files there were single quotes ;)

This comment has been minimized.

@alexsasharegan

alexsasharegan Jul 7, 2017

Contributor

My darn editor tools! Like I said before, if I can configure the tool to format for me, I'm good. I guess prettier prefers double quotes.

This comment has been minimized.

@mosinve

mosinve Jul 7, 2017

Member

i'll add rules for double quotes at eslint config :)

@mosinve

mosinve approved these changes Jul 7, 2017

Alex Regan added some commits Jul 7, 2017

Alex Regan
Merge branch 'master' of https://github.com/bootstrap-vue/bootstrap-vue
… into refactor/utils

# Conflicts:
#	lib/components/table.vue
Alex Regan
Merge branch 'refactor/utils' of github.com:alexsasharegan/bootstrap-…
…vue into refactor/utils

# Conflicts:
#	lib/components/table.vue
@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jul 8, 2017

Any last thoughts on this? I'd love to see this merged soon so I can pull in the changes and start using them in the FC PR.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 8, 2017

I have no objections to merge.

Shall I press the button? :)

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jul 8, 2017

I say go for it! I just never want to merge my own large changes. Keep it democratic.

@tmorehouse tmorehouse merged commit 2ee9ed6 into bootstrap-vue:master Jul 8, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 8, 2017

We can always revert if there is an issue

alexsasharegan pushed a commit to alexsasharegan/bootstrap-vue that referenced this pull request Jul 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment