New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): Remove redundant ARIA roles from b-table #662

Merged
merged 2 commits into from Jul 7, 2017

Conversation

Projects
None yet
1 participant
@tmorehouse
Member

tmorehouse commented Jul 7, 2017

Roles grid and row are implied automatically by current table semantic markup, and not necessary.

Based on chrome Accessibility Plugin Audit of renderd <b-table>.

fix(table): Remove redundant ARIA roles from table
Role `grid` and `row` are implied automatically by current table semantic markup, and not necessary.

Based on chrome Accessibility Plugin Audit  of renderd `<b-table>`

@tmorehouse tmorehouse added this to the v0.19.0 milestone Jul 7, 2017

@tmorehouse tmorehouse requested a review from pi0 Jul 7, 2017

@tmorehouse tmorehouse merged commit 6919cc5 into master Jul 7, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-table-aria branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment