New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form fieldset): 'label for' prop not being applied to label - ARIA #669

Merged
merged 3 commits into from Jul 7, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Jul 7, 2017

User supplied for target was not being applied to the label properly. This PR fixes that.

Also deprecate prop for in favour of label-for

Documentation updated to reflect changes

tmorehouse added some commits Jul 7, 2017

fix(form-fieldset): ARIA 'for' attribute not being applied
When user supplied `for` was supplied it was not being applied to the label.

Also deprecated `for` in favour of `label-for`

@tmorehouse tmorehouse added this to the v0.19.0 milestone Jul 7, 2017

@tmorehouse tmorehouse requested review from pi0 and alexsasharegan Jul 7, 2017

@tmorehouse tmorehouse merged commit aafea81 into master Jul 7, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-form-fieldset-aria branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment