New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle): Remove $root listener on unbind (Issue #680) #698

Merged
merged 2 commits into from Jul 16, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Jul 16, 2017

Add an unbind handler to remove root listener.

The handler is stored on the element in a private property

Addresses issue #680

@tmorehouse tmorehouse added this to the v0.19.0 milestone Jul 16, 2017

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Jul 16, 2017

@tmorehouse tmorehouse changed the title from fix(toggle): Remove $root listener on unbind to fix(toggle): Remove $root listener on unbind (Issue #680) Jul 16, 2017

@alexsasharegan

👍

Use named function for handler
Use named function for handler for better debugging
@alexsasharegan

I always like to leave clues for debugging. Chances are someone will paste in a console error on an issue one day, and it'll be nice to have a reference point.

@tmorehouse tmorehouse merged commit ec5000c into master Jul 16, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-toggle-1 branch Jul 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment