New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collapse): apply bootstrap classes during transition stages (issue #565) #707

Merged
merged 12 commits into from Jul 19, 2017

Conversation

Projects
None yet
1 participant
@tmorehouse
Member

tmorehouse commented Jul 18, 2017

Use the collapse, collapsing and show classes during transition states (issue #565), aligning more closely with Bootstrap V4.alpha.6 (Bonus: removes need for custom scoped CSS)

v-b-toggle directive now adds or removes collapsed class to trigger element based on collapse state, to align with Bootstrap V4 alpha.6 (handy for reflecting state on the button/trigger via CSS)

Addresses issue #565

tmorehouse added some commits Jul 18, 2017

@tmorehouse tmorehouse added this to the v0.19.0 milestone Jul 18, 2017

@tmorehouse tmorehouse requested review from pi0 and alexsasharegan Jul 18, 2017

@tmorehouse tmorehouse changed the title from feat(collapse): apply bootstrap classes during transition stages to [WIP] feat(collapse): apply bootstrap classes during transition stages Jul 18, 2017

tmorehouse added some commits Jul 18, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 18, 2017

Timing issues in the tests (transitions take time to occur). All fixed up..

@tmorehouse tmorehouse removed the Status: WIP label Jul 18, 2017

@tmorehouse tmorehouse changed the title from [WIP] feat(collapse): apply bootstrap classes during transition stages to feat(collapse): apply bootstrap classes during transition stages Jul 18, 2017

@tmorehouse tmorehouse changed the title from feat(collapse): apply bootstrap classes during transition stages to feat(collapse): apply bootstrap classes during transition stages (issue #565) Jul 18, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 18, 2017

JSFiddle mockup: https://jsfiddle.net/vvvss5rb/

In this example, I have overridden the .collapsing class for longer transition time so that one can see the classes being added and removed at appropriate times.

@tmorehouse tmorehouse merged commit 947d253 into master Jul 19, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-collapse-classes branch Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment