New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(navbar-brand): New component <b-navbar-brand> #710

Merged
merged 6 commits into from Jul 19, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Jul 18, 2017

New component for rendering navbar brand content.

Setting props to or href will render a b-link.

If both to and href are not present, then the navbar-brand will be resndered as a div by default (configurable via the tag prop)

tmorehouse added some commits Jul 18, 2017

[navbar-brand] New helper component
Add explicit component for `<b-navbar-brand>`

@tmorehouse tmorehouse added this to the v0.19.0 milestone Jul 18, 2017

@tmorehouse tmorehouse requested review from pi0 and alexsasharegan Jul 18, 2017

</b-link>
<div v-else :is="tag" class="navbar-brand">
<slot></slot>
</div>

This comment has been minimized.

@alexsasharegan

alexsasharegan Jul 19, 2017

Contributor

Might be slightly more declarative just using the <component> tag here. Shows it off clearly as a dynamic tag.

This comment has been minimized.

@tmorehouse

tmorehouse Jul 19, 2017

Member

Yeah, was thinking that

<b-link v-if="isLink"
class="navbar-brand"
v-bind="linkProps"
@click="$emit('click', $event)">

This comment has been minimized.

@alexsasharegan

alexsasharegan Jul 19, 2017

Contributor

Once we hit v2.4 as a peer dependency with Vue, we can start using v-bind="$attrs" v-on="$listeners" to proxy everything off to link or whatever. And that is glorious!

This comment has been minimized.

@tmorehouse

tmorehouse Jul 19, 2017

Member

Excellent. Will be nice when that happens

@tmorehouse tmorehouse merged commit 721292c into master Jul 19, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-navbar-brand branch Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment