New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdowns): Change how dropdown items are highlighted #717

Merged
merged 7 commits into from Jul 21, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Jul 20, 2017

Changes the highlighting method of focused items (instead of using active class state).

Slight tweaks to the :hover and :focus states CSS to remove ugly blue-line outline on focus and add slightly darker background color (default BS V4 contrast ratio is waaay too low to notice the hover/focus state)

@tmorehouse tmorehouse added this to the v0.19.0 milestone Jul 20, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 20, 2017

Preview of the new styling (hover, focus, and keyboard selection will appear in this style):
image

And when link is "active" (from clicking or navigation) it looks as so:
image

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 20, 2017

Addresses some concerns of #716 and other discussions with the @dev team

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 20, 2017

Depending on CSS loader, might need to add !important on the background color.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 20, 2017

THe only issue that may crop up is that the active state takes precedence over hover/focus, so the focus state will not be as obvious due to the lack of outline.

@tmorehouse tmorehouse requested review from alexsasharegan and mosinve Jul 21, 2017

@mosinve

This comment has been minimized.

Member

mosinve commented Jul 21, 2017

Looks nice, better that before ) and there's no hardcoded '.active' class 👍

@tmorehouse tmorehouse merged commit a02270e into master Jul 21, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-dropdowns branch Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment