New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-select): Add multiple select support (issue #619) #731

Merged
merged 12 commits into from Jul 28, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Jul 24, 2017

Adds multiple select support to form-select (addresses issue #619)

new props:

  • multiple enabled multiple select support when set to true
  • multiple-size set the number of rows displayed in multiple select. Defaults to browser default size

form-options.js mixin updated to support multiple select.

Updated documentation

tmorehouse added some commits Jul 24, 2017

[form-select] Support multiple select
Adds multiple elect support to form-select.

new props:
- `multiple` enabled multiple select support
- `multiple-size` set teh number of rows displayed in multiple select. Defaults to browser default size

@tmorehouse tmorehouse added this to the v0.19.0 milestone Jul 24, 2017

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Jul 24, 2017

@mosinve

This comment has been minimized.

Member

mosinve commented Jul 24, 2017

About multiple-size prop, why don't use common known html prop size, it will be easier to move from pure HTML to BV components.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Jul 24, 2017

Problem is, size shouldn't be applied to regular select (non multiple), and we already have a size prop that controls the text size of form-controls and buttons (size="lg" and size="sm"), so it would get confusing with the two. This way it is more explicit as to what it is applied to.

In reality, the select size attribute really should have been called rows in native HTML (like textarea has rows). Text inputs also have a native size attribute (for width in characters), which conflicts with the bootstrap form-control sizes (lg and sm), but since form-controls have the .form-control class, the size prop on text inputs isn't needed (as they will always be 100% of the width of their container).

@tmorehouse tmorehouse changed the title from feat(form-select): Add multiple select support to feat(form-select): Add multiple select support (issue #619) Jul 25, 2017

tmorehouse and others added some commits Jul 25, 2017

@tmorehouse tmorehouse merged commit 19bf2f5 into master Jul 28, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-select-multi branch Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment