New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-input): Add autocomplete prop #750

Merged
merged 2 commits into from Jul 29, 2017

Conversation

Projects
None yet
3 participants
@paulgv
Contributor

paulgv commented Jul 29, 2017

It would be nice to be able to control browsers autocomplete features with an autocomplete prop on form inputs.

paulgv and others added some commits Jul 29, 2017

[form-input] Handle empty string for autocomplete
Safety measure to ensure that the attribute `autocomplete` does not render if empty string provided

@tmorehouse tmorehouse added this to the v0.19.0 milestone Jul 29, 2017

@tmorehouse tmorehouse changed the title from Add autocomplete prop to form inputs to feat(form-input): Add autocomplete prop Jul 29, 2017

@tmorehouse tmorehouse merged commit d686787 into bootstrap-vue:master Jul 29, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Jul 29, 2017

I've been adding autocomplete into my <b-form-input>'s without any issue. Why does this need to be a prop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment