New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(navbar-brand): Refactored component logic #759

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 1, 2017

After working on documentation for b-navbar I discovered a few issues with b-navbar-brand. So I have refactored the template and props (and made it work more like b-button)

@tmorehouse tmorehouse added this to the v0.19.0 milestone Aug 1, 2017

@tmorehouse tmorehouse requested review from alexsasharegan and mosinve Aug 1, 2017

@tmorehouse tmorehouse added the Type: Bug label Aug 1, 2017

@mosinve

mosinve approved these changes Aug 1, 2017

@tmorehouse tmorehouse merged commit c752fc8 into master Aug 1, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-navbar-brand branch Aug 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment