New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-select): Allow selectSize to be set when not in multiple mode (Issue #761) #762

Merged
merged 4 commits into from Aug 1, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 1, 2017

Allows the select native size attribute to be set (via the prop select-size), even when not in multiple mode. Only has any effect when select-size > 1. Custom select styling is removed when in multiple mode or select-size > 1.

Changes multiple-size attribute to select-size (multiple-size was not available in v0.18.0, so deprecation is not needed)

Addresses issue #761

tmorehouse added some commits Aug 1, 2017

feat(form-select): Allow selectSize to be set when not in multiple mode
Allows the select native `size` attribute to be set (via the prop `select-size`), even when not in multiple mode.  Only has any effect when `select-size > 1`.  custom select styling is removed when in `multiple` mode or `select-size > 1`.

Changes `multiple-size` attribute to `select-size` (`multiple-size` was not available in v0.18.0, so deprecation is not needed)

@tmorehouse tmorehouse added this to the v0.19.0 milestone Aug 1, 2017

@tmorehouse tmorehouse requested review from alexsasharegan and mosinve Aug 1, 2017

@tmorehouse tmorehouse changed the title from feat(form-select): Allow selectSize to be set when not in multiple mode to feat(form-select): Allow selectSize to be set when not in multiple mode (Issue #761) Aug 1, 2017

@@ -78,7 +78,7 @@ export default {
<!-- form-select-1.vue -->
```
#### Slect sizing (displayed rows):
#### Select sizing (displayed rows):

This comment has been minimized.

@tmorehouse
@@ -4,7 +4,7 @@
:id="id || null"
v-model="localValue"
:multiple="multiple || null"
:size="(multiple || selectSize > 1) ? multipleSize : null"
:size="(multiple || selectSize > 1) ? selectSize : null"

This comment has been minimized.

@tmorehouse

tmorehouse Aug 1, 2017

Member

Good catch! thanks!

This comment has been minimized.

@mosinve

mosinve Aug 1, 2017

Member

😉

@mosinve

mosinve approved these changes Aug 1, 2017

@tmorehouse tmorehouse merged commit 6f04090 into master Aug 1, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-select-size branch Aug 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment