New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): add colon for binding `aria-label` #768

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
2 participants
@ReedSun
Contributor

ReedSun commented Aug 3, 2017

I think this place maybe forget colon to bind attribute aria-label . So I make this PR.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Aug 3, 2017

Good Catch! Thanks!

@tmorehouse tmorehouse changed the title from fix(alert): add the colon for binding `aria-label` to fix(alert): add colon for binding `aria-label` Aug 3, 2017

@tmorehouse tmorehouse added this to the v0.19.0 milestone Aug 3, 2017

@tmorehouse tmorehouse merged commit 93b009f into bootstrap-vue:master Aug 3, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment