New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert): Hide dismiss button for auto-dismissing alerts #791

Merged
merged 3 commits into from Aug 10, 2017

Conversation

Projects
None yet
4 participants
@tmorehouse
Member

tmorehouse commented Aug 10, 2017

When rendering an auto-dismissing alert, hide the dismiss button.

Quick workaround for issue #718

tmorehouse added some commits Aug 10, 2017

[alert] update example files
Remove dismissible from countdown alert

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Aug 10, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 10, 2017

Codecov Report

Merging #791 into dev will increase coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #791      +/-   ##
=========================================
+ Coverage   39.6%   39.61%   +<.01%     
=========================================
  Files         68       68              
  Lines       2207     2209       +2     
  Branches     632      632              
=========================================
+ Hits         874      875       +1     
- Misses      1171     1172       +1     
  Partials     162      162
Impacted Files Coverage Δ
lib/components/alert.vue 61.53% <60%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c234580...a85e450. Read the comment docs.

@tmorehouse tmorehouse merged commit 080bb20 into dev Aug 10, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-alert branch Aug 10, 2017

@tmorehouse tmorehouse modified the milestones: v0.19.1, v0.20.0 Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment