New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(navbar-brand): Removed erroneous this in template #806

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Aug 10, 2017

Removed erroneous this in template

Should address issue #805

fix(navbar-brand): Removed erroneous this in template
Removed erroneous `this` in template

@tmorehouse tmorehouse requested review from pi0 and alexsasharegan Aug 10, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 10, 2017

Codecov Report

Merging #806 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #806   +/-   ##
=======================================
  Coverage   39.61%   39.61%           
=======================================
  Files          68       68           
  Lines        2209     2209           
  Branches      632      632           
=======================================
  Hits          875      875           
  Misses       1172     1172           
  Partials      162      162
Impacted Files Coverage Δ
lib/components/navbar-brand.vue 58.82% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7bdaf...8ce09ba. Read the comment docs.

@pi0

pi0 approved these changes Aug 10, 2017

@tmorehouse tmorehouse merged commit 0842043 into dev Aug 10, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-navbar-brand branch Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment