New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(card): Fix classes, variants, borders [v4-beta] #815

Merged
merged 9 commits into from Aug 12, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 12, 2017

Adds new prop bordered to gt a bordered variant (replaces outline variants)

Needs test suite (and demo.html) to be updated to handle expected class names (test currently fail)

tmorehouse added some commits Aug 12, 2017

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Aug 12, 2017

@tmorehouse tmorehouse changed the title from fix(card): Fix classes, varians, borders to fix(card): Fix classes, varians, borders [v4-beta] Aug 12, 2017

@tmorehouse tmorehouse changed the title from fix(card): Fix classes, varians, borders [v4-beta] to fix(card): Fix classes, variants, borders [v4-beta] Aug 12, 2017

tmorehouse added some commits Aug 12, 2017

@bootstrap-vue bootstrap-vue deleted a comment from codecov-io Aug 12, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 12, 2017

Codecov Report

Merging #815 into 1.x will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #815      +/-   ##
==========================================
- Coverage   40.34%   40.32%   -0.03%     
==========================================
  Files          68       68              
  Lines        2186     2185       -1     
  Branches      620      621       +1     
==========================================
- Hits          882      881       -1     
  Misses       1146     1146              
  Partials      158      158
Impacted Files Coverage Δ
lib/components/card.vue 76.47% <ø> (-1.31%) ⬇️
lib/components/carousel.vue 37.06% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8222222...20d02d8. Read the comment docs.

@tmorehouse tmorehouse merged commit fc26811 into 1.x Aug 12, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-v4-cards branch Aug 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment