New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdowns): Focus dropdown item on hover #823

Merged
merged 11 commits into from Aug 12, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Aug 12, 2017

Prevent two items from visually having the focus/hover states.

Also removed focusing of dropdown-header elements, as per discussion in twbs/bootstrap#23336 (users should add an aria-describedby attribute on dropdown-items that point to their header element, if the dropdown-item needs context from the header)

Also name-spaced custom CSS (adding class .b-dropdown and b-navdropdown on the root elements)

tmorehouse added some commits Aug 12, 2017

Update dropdown-header.vue
remove tabindex

@tmorehouse tmorehouse requested a review from pi0 Aug 12, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 12, 2017

Codecov Report

Merging #823 into 1.x will decrease coverage by 0.05%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #823      +/-   ##
==========================================
- Coverage   40.58%   40.52%   -0.06%     
==========================================
  Files          68       68              
  Lines        2198     2201       +3     
  Branches      622      626       +4     
==========================================
  Hits          892      892              
- Misses       1148     1151       +3     
  Partials      158      158
Impacted Files Coverage Δ
lib/mixins/dropdown.js 6.41% <0%> (-2.46%) ⬇️
lib/components/dropdown.vue 73.33% <100%> (+4.1%) ⬆️
lib/components/dropdown-header.vue 63.63% <100%> (ø) ⬆️
lib/components/nav-item-dropdown.vue 50% <100%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c172c1...9876ea1. Read the comment docs.

@tmorehouse tmorehouse requested review from alexsasharegan and mosinve Aug 12, 2017

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 12, 2017

@pi0

This comment has been minimized.

Member

pi0 commented Aug 12, 2017

Bootstrap JS still has this issue 😂

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Aug 12, 2017

Heheh

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Aug 12, 2017

Similar PR #825 for the dev branch

@tmorehouse tmorehouse merged commit 2e863d9 into 1.x Aug 12, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-1x-dropdowns branch Aug 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment