New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(card): change prop no-block to no-body #826

Merged
merged 10 commits into from Aug 12, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 12, 2017

Change prop no-block to no-body to better reflect V4.beta classes

Update documentation

tmorehouse added some commits Aug 12, 2017

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 12, 2017

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Aug 12, 2017

tmorehouse added some commits Aug 12, 2017

[card] Add slots body and no-body
Alternative means to place body and no-body sections
Update meta.json
Document body and no-body slots
@codecov-io

This comment has been minimized.

codecov-io commented Aug 12, 2017

Codecov Report

Merging #826 into 1.x will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##              1.x     #826   +/-   ##
=======================================
  Coverage   39.22%   39.22%           
=======================================
  Files          69       69           
  Lines        2320     2320           
  Branches      658      658           
=======================================
  Hits          910      910           
  Misses       1253     1253           
  Partials      157      157
Impacted Files Coverage Δ
lib/components/card.vue 76.47% <75%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54a01e...f7ccbdb. Read the comment docs.

@tmorehouse tmorehouse merged commit 664bc98 into 1.x Aug 12, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-1x-card branch Aug 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment