New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(card): functional components for card 馃幋 #827

Merged
merged 16 commits into from Aug 13, 2017

Conversation

Projects
None yet
4 participants
@alexsasharegan
Contributor

alexsasharegan commented Aug 12, 2017

No description provided.

Alex Regan
@codecov-io

This comment has been minimized.

codecov-io commented Aug 12, 2017

Codecov Report

Merging #827 into 1.x will increase coverage by 0.69%.
The diff coverage is 88.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #827      +/-   ##
==========================================
+ Coverage   39.06%   39.75%   +0.69%     
==========================================
  Files          69       73       +4     
  Lines        2314     2324      +10     
  Branches      659      662       +3     
==========================================
+ Hits          904      924      +20     
+ Misses       1253     1243      -10     
  Partials      157      157
Impacted Files Coverage 螖
lib/components/card-header.js 100% <100%> (酶)
tests/helpers.js 87.93% <100%> (+3.44%) 猬嗭笍
lib/components/card-footer.js 100% <100%> (酶)
lib/utils/pluckProps.js 100% <100%> (酶)
lib/components/card-img.js 71.42% <71.42%> (酶)
lib/components/card-group.js 71.42% <71.42%> (酶)
lib/components/card.js 95.23% <95.23%> (酶)
lib/components/card-group.vue
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 664bc98...94d843d. Read the comment docs.

@alexsasharegan alexsasharegan changed the title from [WIP] feat(card): functional components for card 馃幋 to feat(card): functional components for card 馃幋 Aug 12, 2017

@alexsasharegan alexsasharegan requested review from tmorehouse, pi0 and mosinve Aug 12, 2017

@pi0

This comment has been minimized.

Member

pi0 commented Aug 12, 2017

@alexsasharegan What's your idea moving examples ~> tests/fixtures as they are really fixtures now :))

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Aug 12, 2017

Yeah.. they aren't really examples, and we wouldn't want people fiddling with them which would interfere with tests.

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Aug 13, 2017

Perfect! That seems right to me. Let me make that change once I get home!

Alex Regan

@alexsasharegan alexsasharegan merged commit 2089252 into 1.x Aug 13, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@alexsasharegan alexsasharegan deleted the feat/card-fc branch Aug 13, 2017

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Aug 13, 2017

Should fixtures be under the tests directory (i.e. tests/fixtures/)

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Aug 13, 2017

@tmorehouse I'll fix that on the next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment