New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: link, breadcrumb, & button FC’s #830

Merged
merged 32 commits into from Aug 14, 2017

Conversation

Projects
None yet
5 participants
@alexsasharegan
Contributor

alexsasharegan commented Aug 12, 2017

Requires the card PR that includes a util before moving forward.

@codecov-io

This comment has been minimized.

codecov-io commented Aug 13, 2017

Codecov Report

Merging #830 into 1.x will not change coverage.
The diff coverage is 68.99%.

Impacted file tree graph

@@           Coverage Diff           @@
##              1.x     #830   +/-   ##
=======================================
  Coverage   39.62%   39.62%           
=======================================
  Files          73       75    +2     
  Lines        2337     2337           
  Branches      666      662    -4     
=======================================
  Hits          926      926           
+ Misses       1254     1248    -6     
- Partials      157      163    +6
Impacted Files Coverage Δ
lib/components/dropdown.vue 73.33% <ø> (ø) ⬆️
lib/components/pagination-nav.vue 11.38% <ø> (ø) ⬆️
lib/components/modal.vue 9.43% <ø> (ø) ⬆️
lib/components/dropdown-item.vue 69.23% <0%> (ø) ⬆️
lib/components/nav-item.vue 69.23% <0%> (ø) ⬆️
lib/components/carousel.vue 35.15% <0%> (ø) ⬆️
lib/components/breadcrumb-item.js 100% <100%> (ø)
lib/mixins/link.js 21.42% <100%> (-41.43%) ⬇️
tests/helpers.js 84.48% <100%> (-3.45%) ⬇️
lib/components/breadcrumb-link.js 100% <100%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2089252...9b7b2e7. Read the comment docs.

Alex Regan
@@ -56,7 +56,7 @@
"docs-dev": "nuxt dev",
"docs-gen": "nuxt generate",
"docs-publish": "./build/gh-pages",
"test": "jest --maxWorkers=1",
"test": "jest",

This comment has been minimized.

@tmorehouse

tmorehouse Aug 13, 2017

Member

Maybe set this to 2

Alex Regan added some commits Aug 13, 2017

Alex Regan
Alex Regan
Alex Regan

@alexsasharegan alexsasharegan changed the title from [WIP] feat: link & button FC’s to feat: link, breadcrumb, & button FC’s Aug 13, 2017

@alexsasharegan alexsasharegan added this to the v1.0.0 milestone Aug 13, 2017

@alexsasharegan alexsasharegan requested review from pi0 and mosinve Aug 13, 2017

@pi0

This comment has been minimized.

Member

pi0 commented Aug 13, 2017

Something probably not related to this PR, but most Linters prefer single quotes why are we using such customized rules ? :))

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Aug 13, 2017

I think there's an open PR for linter settings. I just let my editor do the formatting for me, so dive into the eslint stuff and set it up however you'd like!

@pi0

This comment has been minimized.

Member

pi0 commented Aug 13, 2017

Will locally check #792 soon :)

@pi0

pi0 approved these changes Aug 13, 2017

LGTM (not locally tested)

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Aug 13, 2017

I'm pretty happy we (@tmorehouse & I) got prop sync working on a functional component. Could be wrong, but we might literally be the first to do that.

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Aug 14, 2017

Fixed a couple components referencing button.vue directly, which led me to mess with modal. I fixed a lot of spelling errors in the docs there, and a quirky bug in the demo. Basically, you could keep submitting names without the modal closing by using the enter key. I fixed that, and in the process show off a couple ways to work with modal events.

Alex Regan added some commits Aug 14, 2017

There are several methods that you can employ to toggle he visibility of `<b-modal>`.
#### Using `v-b-modal` directive (recommended)
### Using `v-b-modal` directive (recommended)

This comment has been minimized.

@tmorehouse

tmorehouse Aug 14, 2017

Member

This should be 4 hashes, or change the ones below to 3 hashes, since the headings are at the same sub level under Toggle Modal Visibility

This comment has been minimized.

@alexsasharegan

alexsasharegan Aug 14, 2017

Contributor

The whole thing was freaking out about not descending H's in proper order. I believe I've basically taken everything back a step.

This comment has been minimized.

@mosinve

mosinve Aug 14, 2017

Member

Yep, H's levels have to be changed

mosinve added some commits Aug 14, 2017

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Aug 14, 2017

Okay, I've gone through the docs page-by-page. I've cleared all the console errors I could find, and tried to get any spelling typos along the way.

@mosinve, are you done going through docs too? I'm good to go now.

@mosinve

This comment has been minimized.

Member

mosinve commented Aug 14, 2017

Yep, i think it's finished ))

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Aug 14, 2017

Cool, once @tmorehouse approves, I'll squash & merge.

@mosinve

This comment has been minimized.

Member

mosinve commented Aug 14, 2017

+1,380 −1,677 - lib going to be slightly slimmer ))))

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Aug 14, 2017

Haha but it's mostly deleting all the old jsfiddle's!

@@ -10,11 +10,11 @@ regular links or router links.
<b-pagination-nav base-url="#" :number-of-pages="10" v-model="currentPage" />
<h6 class="mt-4">With link generator function</h6>
<b-pagination-nav link-gen="linkGen" :number-of-pages="10" v-model="currentPage" />
<b-pagination-nav :link-gen="linkGen" :number-of-pages="10" v-model="currentPage" />

This comment has been minimized.

@tmorehouse

@alexsasharegan alexsasharegan merged commit cdbef2d into 1.x Aug 14, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@alexsasharegan alexsasharegan deleted the feat/link-fc branch Aug 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment