New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(progress): Add height prop #837

Merged
merged 5 commits into from Aug 14, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Aug 14, 2017

Add support for setting the height of the progress bar

Also includes expanded documentation

tmorehouse added some commits Aug 14, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 14, 2017

Codecov Report

Merging #837 into 1.x will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##              1.x    #837      +/-   ##
=========================================
- Coverage   39.62%   39.6%   -0.02%     
=========================================
  Files          75      75              
  Lines        2337    2338       +1     
  Branches      662     663       +1     
=========================================
  Hits          926     926              
- Misses       1248    1249       +1     
  Partials      163     163
Impacted Files Coverage Δ
lib/components/progress.vue 41.17% <66.66%> (-2.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdbef2d...994deec. Read the comment docs.

@mosinve

This comment has been minimized.

Member

mosinve commented Aug 14, 2017

Whoa!!! we have a progress bar? o_O

@tmorehouse tmorehouse merged commit 8a52b93 into 1.x Aug 14, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-progress branch Aug 14, 2017

@tmorehouse tmorehouse referenced this pull request Aug 14, 2017

Closed

[Informational] Bootstrap V4.beta 1, 2 & 3 ship list #747

45 of 56 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment