New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): Change classes from .hidden-* to .d-* #840

Merged
merged 2 commits into from Aug 14, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 14, 2017

V4.beta has removed the .hidden-* classes, so we must use the .d-* classes for hiding on XS screens.

For pagination and pagination-nav we replaced .hidden-sx-down with .d-none + .d-sm-flex

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 14, 2017

@tmorehouse tmorehouse requested review from pi0 and alexsasharegan Aug 14, 2017

@tmorehouse tmorehouse referenced this pull request Aug 14, 2017

Closed

[Informational] Bootstrap V4.beta 1, 2 & 3 ship list #747

45 of 56 tasks complete

@tmorehouse tmorehouse merged commit 0f543a1 into 1.x Aug 14, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-pagination branch Aug 14, 2017

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Aug 14, 2017

Well this is inconvenient. Refactoring responsive breakpoint classes is not a favorite of mine...

I suppose it saves on BS4's gratuitous lib size though.

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Aug 14, 2017

Yeah.

Not sure of any other components that were using the .hidden-<breakpoint>-down/up classes (other than pagination/pagination-nav)

The removal of these classes now mean you have to add at least two classes to your elements (one for hiding, and one for displaying), but it is more flexible

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Aug 14, 2017

It's a big deal for my production app. I'll be doing some find & replace by hand work when I upgrade...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment