New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-row): New functional component #844

Merged
merged 6 commits into from Aug 14, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 14, 2017

Similar to native .row class, but created a row using .form-row class which has tighter margins.

Created as a functional component, and allows for a custom tag (defaults to div)

Includes tests

tmorehouse added some commits Aug 14, 2017

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 14, 2017

@tmorehouse tmorehouse requested a review from alexsasharegan Aug 14, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 14, 2017

Codecov Report

Merging #844 into 1.x will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             1.x     #844      +/-   ##
=========================================
+ Coverage   39.8%   39.85%   +0.05%     
=========================================
  Files         75       76       +1     
  Lines       2339     2341       +2     
  Branches     663      663              
=========================================
+ Hits         931      933       +2     
  Misses      1245     1245              
  Partials     163      163
Impacted Files Coverage Δ
lib/components/form-row.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467ec27...a624d86. Read the comment docs.

@tmorehouse tmorehouse requested a review from pi0 Aug 14, 2017

@tmorehouse tmorehouse merged commit 1e0f313 into 1.x Aug 14, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-form-row branch Aug 14, 2017

@tmorehouse tmorehouse referenced this pull request Aug 15, 2017

Closed

[Informational] Bootstrap V4.beta 1, 2 & 3 ship list #747

45 of 56 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment