New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-text): New functional component #846

Merged
merged 11 commits into from Aug 15, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 15, 2017

New b-form-text (AKA form-help) functional component

Defaults to tag <small> and text-muted variant

Can be placed in inline mode (inline prop) which removed the .form-text class

tmorehouse added some commits Aug 15, 2017

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 15, 2017

tmorehouse added some commits Aug 15, 2017

@tmorehouse tmorehouse requested a review from alexsasharegan Aug 15, 2017

Alex Regan and others added some commits Aug 15, 2017

Alex Regan
@codecov-io

This comment has been minimized.

codecov-io commented Aug 15, 2017

Codecov Report

Merging #846 into 1.x will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              1.x    #846      +/-   ##
=========================================
+ Coverage   39.85%   39.9%   +0.05%     
=========================================
  Files          76      77       +1     
  Lines        2341    2343       +2     
  Branches      663     663              
=========================================
+ Hits          933     935       +2     
  Misses       1245    1245              
  Partials      163     163
Impacted Files Coverage Δ
lib/components/form-text.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e1d4c9...cf9c2d3. Read the comment docs.

@tmorehouse tmorehouse merged commit 2ed7470 into 1.x Aug 15, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse-form-text branch Aug 15, 2017

@tmorehouse tmorehouse referenced this pull request Aug 15, 2017

Closed

[Informational] Bootstrap V4.beta 1, 2 & 3 ship list #747

45 of 56 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment