New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdowns): functional dropdown components and testing #848

Merged
merged 2 commits into from Aug 15, 2017

Conversation

Projects
None yet
4 participants
@alexsasharegan
Contributor

alexsasharegan commented Aug 15, 2017

No description provided.

@alexsasharegan alexsasharegan requested a review from tmorehouse Aug 15, 2017

@alexsasharegan alexsasharegan assigned mosinve and unassigned mosinve Aug 15, 2017

@alexsasharegan alexsasharegan requested a review from mosinve Aug 15, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 15, 2017

Codecov Report

Merging #848 into 1.x will increase coverage by 0.67%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #848      +/-   ##
==========================================
+ Coverage   40.27%   40.94%   +0.67%     
==========================================
  Files          84       84              
  Lines        2364     2325      -39     
  Branches      667      658       -9     
==========================================
  Hits          952      952              
+ Misses       1249     1222      -27     
+ Partials      163      151      -12
Impacted Files Coverage Δ
lib/components/dropdown-item.js 100% <100%> (ø)
lib/components/dropdown-item-button.js 33.33% <33.33%> (ø)
lib/components/dropdown-header.js 50% <50%> (ø)
lib/components/dropdown-divider.js 50% <50%> (ø)
tests/helpers.js 87.93% <0%> (+3.44%) ⬆️
lib/mixins/dropdown.js 35.89% <0%> (+29.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f88ab23...17ed015. Read the comment docs.

@alexsasharegan

This comment has been minimized.

Contributor

alexsasharegan commented Aug 15, 2017

Moving the code coverage needle 0.67% at a time 👍

@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Aug 15, 2017

That might actually be a .666% rounded up to two decimals :p

props.tag,
mergeData(data, {
staticClass: "dropdown-header",
attrs: { tabindex: "-1" }

This comment has been minimized.

@tmorehouse

tmorehouse Aug 15, 2017

Member

TabIndex no longer needed.

This comment has been minimized.

@tmorehouse

tmorehouse Aug 15, 2017

Member

The main dropdown mixin doesn't focus headers any more. users will need to point aria-describedby attribute to a header with an ID.

This comment has been minimized.

@alexsasharegan

alexsasharegan Aug 15, 2017

Contributor

Should I remove this then?

This comment has been minimized.

@alexsasharegan

alexsasharegan Aug 15, 2017

Contributor

Oh, you did!

bDropdownItem,
bDropdownItem as bDdItem,

This comment has been minimized.

@tmorehouse

@alexsasharegan alexsasharegan merged commit 2bd562b into 1.x Aug 15, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@alexsasharegan alexsasharegan deleted the feat/dropdown-fcs branch Aug 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment