New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nav): new functional nav components #864

Merged
merged 10 commits into from Aug 16, 2017

Conversation

Projects
None yet
4 participants
@alexsasharegan
Contributor

alexsasharegan commented Aug 15, 2017

No description provided.

@codecov-io

This comment has been minimized.

codecov-io commented Aug 15, 2017

Codecov Report

Merging #864 into 1.x will decrease coverage by 0.84%.
The diff coverage is 42.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #864      +/-   ##
==========================================
- Coverage   41.39%   40.55%   -0.85%     
==========================================
  Files          86       85       -1     
  Lines        2319     2244      -75     
  Branches      659      640      -19     
==========================================
- Hits          960      910      -50     
+ Misses       1210     1182      -28     
- Partials      149      152       +3
Impacted Files Coverage Δ
lib/components/form.js 100% <ø> (ø) ⬆️
lib/components/nav-form.js 0% <0%> (ø)
lib/components/navbar.js 20% <20%> (ø)
lib/components/nav-item.js 50% <50%> (ø)
lib/components/nav.js 50% <50%> (ø)
lib/components/nav-text.js 50% <50%> (ø)
lib/components/navbar-brand.js 57.14% <57.14%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c516d89...c15b72c. Read the comment docs.

render(h, { props, data, children }) {
return h("form", mergeData(data, { class: { "form-inline": props.inline } }), children);
}
};

This comment has been minimized.

@tmorehouse

tmorehouse Aug 15, 2017

Member

Thi will probably conflict with the updated form.vue component in the penndig form-validation branch

Alex Regan and others added some commits Aug 15, 2017

Alex Regan

tmorehouse and others added some commits Aug 16, 2017

Alex Regan
Merge branch '1.x' of github.com:bootstrap-vue/bootstrap-vue into fea…
…t/nav-fcs

# Conflicts:
#	lib/components/form.js
#	lib/components/form.vue
Alex Regan
@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Aug 16, 2017

👍

tag: {
type: String,
default: null
}

This comment has been minimized.

@tmorehouse

tmorehouse Aug 16, 2017

Member

Should this be the props as exported above?

This comment has been minimized.

@alexsasharegan

alexsasharegan Aug 16, 2017

Contributor

Hmm... I set it to div! Let me see how that didn't copy over.

This comment has been minimized.

@alexsasharegan

alexsasharegan Aug 16, 2017

Contributor

I see now. I moved props to an export and then didn't use them.

@alexsasharegan alexsasharegan merged commit ecec23d into 1.x Aug 16, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@alexsasharegan alexsasharegan deleted the feat/nav-fcs branch Aug 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment