New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): Adjustments to form-textarea and form-input #880

Merged
merged 8 commits into from Aug 18, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 18, 2017

Prevent prop mutation errors on form-text area. Minor improvements to form-input

Documentation updates

tmorehouse added some commits Aug 17, 2017

feat(id): safe client side ID generation
If no ID provided, generates one client side during mount (after SSR rehydration)

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 18, 2017

@tmorehouse tmorehouse merged commit 79a7aa8 into 1.x Aug 18, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse/formfixes branch Aug 18, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 18, 2017

Codecov Report

Merging #880 into 1.x will increase coverage by 0.08%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##              1.x    #880      +/-   ##
=========================================
+ Coverage   40.41%   40.5%   +0.08%     
=========================================
  Files          87      88       +1     
  Lines        2239    2244       +5     
  Branches      640     645       +5     
=========================================
+ Hits          905     909       +4     
+ Misses       1178    1177       -1     
- Partials      156     158       +2
Impacted Files Coverage Δ
lib/mixins/id.js 0% <0%> (ø)
lib/components/form-textarea.vue 51.85% <33.33%> (-0.15%) ⬇️
lib/components/form-input.vue 50% <80%> (+9.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2448666...fafe075. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment