New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): Add auto ID generation #888

Merged
merged 4 commits into from Aug 20, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 19, 2017

Adds client side only auto ID generation

tmorehouse added some commits Aug 19, 2017

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 19, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 19, 2017

Codecov Report

Merging #888 into 1.x will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##              1.x     #888   +/-   ##
=======================================
  Coverage   40.74%   40.74%           
=======================================
  Files          88       88           
  Lines        2236     2236           
  Branches      644      644           
=======================================
  Hits          911      911           
  Misses       1169     1169           
  Partials      156      156
Impacted Files Coverage Δ
lib/components/nav-item-dropdown.vue 50% <100%> (ø) ⬆️
lib/components/dropdown.vue 73.33% <80%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada0d82...e0803ae. Read the comment docs.

@tmorehouse tmorehouse requested review from alexsasharegan and mosinve Aug 19, 2017

@tmorehouse tmorehouse merged commit 25a20f2 into 1.x Aug 20, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse/ddown branch Aug 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment