New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown.js): import clickout as a mixin #896

Merged
merged 1 commit into from Aug 20, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 20, 2017

Addresses issue #884

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 20, 2017

@tmorehouse tmorehouse requested a review from alexsasharegan Aug 20, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 20, 2017

Codecov Report

Merging #896 into 1.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             1.x    #896   +/-   ##
=====================================
  Coverage   41.3%   41.3%           
=====================================
  Files         91      91           
  Lines       2276    2276           
  Branches     659     659           
=====================================
  Hits         940     940           
  Misses      1180    1180           
  Partials     156     156
Impacted Files Coverage Δ
lib/mixins/dropdown.js 37.17% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc726d...e28c926. Read the comment docs.

@tmorehouse tmorehouse merged commit 1ba47e5 into 1.x Aug 20, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse/ddown-clickout-1x branch Aug 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment