New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(b-img-lazy): Lazy loaded image component #943

Merged
merged 16 commits into from Aug 31, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 29, 2017

Uses <b-img> as a base.

User can supply a blank-src image URL as a placeholder, or leave null and one will be generated automatically (with optional color set by blank-color).

offset controls how many pixels away from the view port before the image will be shown (defaults to 360)

Provides most of the same props as <b-img> for styling.

This feature is created as a separate component, since b-img is a functional component and cant setup/teardown window event listeners.

Updated docs with example

feat(b-img-lazy): Lazy load image component
Uses `b-img` as a base.

User can supply a `blank-src` image as a placeholder, or leave null and one will be generated automatically (with optional color set by `blank-color`).

`offset` controls how many pixels away from the view port before the image will be shown

Provides most of the same props as `b-img`

tmorehouse added some commits Aug 29, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 29, 2017

Codecov Report

Merging #943 into dev will decrease coverage by 0.23%.
The diff coverage is 29.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #943      +/-   ##
==========================================
- Coverage   37.33%   37.09%   -0.24%     
==========================================
  Files         101      102       +1     
  Lines        2885     2930      +45     
  Branches      862      875      +13     
==========================================
+ Hits         1077     1087      +10     
- Misses       1522     1557      +35     
  Partials      286      286
Impacted Files Coverage Δ
lib/components/img-lazy.vue 22.22% <29.41%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf7c538...741ff53. Read the comment docs.

tmorehouse added some commits Aug 29, 2017

@tmorehouse tmorehouse requested a review from mosinve Aug 29, 2017

@tmorehouse tmorehouse merged commit 68138cb into dev Aug 31, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse/img-lazy branch Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment