New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): Use b-img component and id Mixin #945

Merged
merged 17 commits into from Aug 29, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Aug 29, 2017

Incorporate the new <b-img> component into <carousel-slide>, to allow for easy blank image creation (for maintaining a text only slides aspect ratio)

Incorporate the id mixin to auto ID the carousel client side (on mount) if no IDs are provided.

Additional props for setting image sizes.

Updated docs

tmorehouse added some commits Aug 29, 2017

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 29, 2017

@tmorehouse tmorehouse requested review from pi0 and alexsasharegan Aug 29, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 29, 2017

Codecov Report

Merging #945 into dev will increase coverage by 0.05%.
The diff coverage is 36.84%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #945      +/-   ##
=========================================
+ Coverage   36.25%   36.3%   +0.05%     
=========================================
  Files         102     102              
  Lines        2971    2980       +9     
  Branches      878     882       +4     
=========================================
+ Hits         1077    1082       +5     
- Misses       1584    1588       +4     
  Partials      310     310
Impacted Files Coverage Δ
lib/components/img.js 92.3% <100%> (ø) ⬆️
lib/components/carousel.vue 34.58% <28.57%> (+0.49%) ⬆️
lib/components/carousel-slide.vue 60% <36.36%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4606970...8c18266. Read the comment docs.

@tmorehouse tmorehouse changed the title from feat(carousel) Use b-img component and id Mixin to feat(carousel): Use b-img component and id Mixin Aug 29, 2017

@tmorehouse tmorehouse requested a review from mosinve Aug 29, 2017

tmorehouse and others added some commits Aug 29, 2017

@tmorehouse tmorehouse merged commit d95321b into dev Aug 29, 2017

1 of 2 checks passed

License Compliance FOSSA analyzing commit
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse/carousel branch Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment