New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Side bar navigation not accessible on small screens #946

Merged
merged 10 commits into from Aug 29, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Aug 29, 2017

The sidebar is not accessible when screen are XS size.

fixes issue #944

tmorehouse added some commits Aug 29, 2017

Update docs.min.css
Sync with latest bootstrap docs CSS
@codecov-io

This comment has been minimized.

codecov-io commented Aug 29, 2017

Codecov Report

Merging #946 into dev will increase coverage by 1.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #946      +/-   ##
==========================================
+ Coverage   36.25%   37.56%   +1.31%     
==========================================
  Files         102      101       -1     
  Lines        2971     2854     -117     
  Branches      878      850      -28     
==========================================
- Hits         1077     1072       -5     
+ Misses       1584     1500      -84     
+ Partials      310      282      -28
Impacted Files Coverage Δ
lib/components/nav-toggle.vue 35% <ø> (ø) ⬆️
lib/components/collapse.vue 66.17% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6be7390...c461a15. Read the comment docs.

@tmorehouse tmorehouse requested a review from mosinve Aug 29, 2017

Update docs.vue
Add spaced DIV visible only on XS screens
@@ -5,6 +5,7 @@
<div class="container-fluid">
<div class="row flex-xl-nowrap2">
<div class="col-12 col-md-3 col-xl-2 bd-sidebar">
<div class="d-block d-sm-none py-4 mt-3"></div>

This comment has been minimized.

@tmorehouse

tmorehouse Aug 29, 2017

Member

Temporary hack to push search & toggler in view on XS screens

This comment has been minimized.

@mosinve

mosinve Aug 29, 2017

Member

no positive effect

This comment has been minimized.

@mosinve

mosinve Aug 29, 2017

Member

image
toggler showed, but its not clickable

This comment has been minimized.

@tmorehouse

tmorehouse Aug 29, 2017

Member

ah may need to add v-b-toggle directive...

This comment has been minimized.

@tmorehouse

tmorehouse Aug 29, 2017

Member

My mistake. I had component <nav-toggle> instead of <b-nav-toggle>

This comment has been minimized.

@tmorehouse

tmorehouse Aug 29, 2017

Member

Note search currently doesn't work from what I can see. Its just there for when search will be applied.

I wonder if that should be hidden, or disabled?

tmorehouse added some commits Aug 29, 2017

merge in tether removal (#948)
* fix(mixins): remove tether popover mixin

* delete popover mixin
@tmorehouse

This comment has been minimized.

Member

tmorehouse commented Aug 29, 2017

Is the toggle working correctly now?

@tmorehouse tmorehouse merged commit 4666b37 into dev Aug 29, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse/docs-nav branch Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment