New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nav-dropdown): Fix right alignment in <b-nav> #962

Merged
merged 5 commits into from Aug 31, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 30, 2017

Work in progress

possible fix for issue #952

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 30, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 30, 2017

Codecov Report

Merging #962 into dev will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #962      +/-   ##
==========================================
+ Coverage   37.61%   37.63%   +0.02%     
==========================================
  Files         101      101              
  Lines        2863     2864       +1     
  Branches      855      855              
==========================================
+ Hits         1077     1078       +1     
  Misses       1503     1503              
  Partials      283      283
Impacted Files Coverage Δ
lib/components/nav-item-dropdown.vue 46.66% <100%> (ø) ⬆️
lib/mixins/dropdown.js 35.96% <80%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c457e7...fa2a89b. Read the comment docs.

tmorehouse added some commits Aug 31, 2017

@tmorehouse tmorehouse changed the title from [WIP] fix(nav-dropdown): Fix right alignment in <b-nav> to fix(nav-dropdown): Fix right alignment in <b-nav> Aug 31, 2017

@tmorehouse tmorehouse removed the Status: WIP label Aug 31, 2017

@tmorehouse tmorehouse merged commit 9598763 into dev Aug 31, 2017

1 of 2 checks passed

License Compliance FOSSA analyzing commit
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse/dropdown branch Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment