New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip+popover): Hide tooltip/popover when $route changes #965

Merged
merged 1 commit into from Aug 30, 2017

Conversation

Projects
None yet
3 participants
@tmorehouse
Member

tmorehouse commented Aug 30, 2017

Addresses issue #964

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 30, 2017

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Aug 30, 2017

@pi0

pi0 approved these changes Aug 30, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 30, 2017

Codecov Report

Merging #965 into dev will decrease coverage by 0.17%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #965      +/-   ##
==========================================
- Coverage   37.61%   37.44%   -0.18%     
==========================================
  Files         101      101              
  Lines        2863     2876      +13     
  Branches      855      859       +4     
==========================================
  Hits         1077     1077              
- Misses       1503     1512       +9     
- Partials      283      287       +4
Impacted Files Coverage Δ
lib/classes/tooltip.js 5.36% <0%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3adbcb5...4d0a0be. Read the comment docs.

@tmorehouse tmorehouse merged commit e403225 into dev Aug 30, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the fix/964 branch Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment