New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scrollspy): Undefined value during bind() #967

Merged
merged 1 commit into from Aug 30, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 30, 2017

Fixes missing reference to vnode on initial bind()

Addresses issue #963

fix(scrollspy): Undefined value during bind()
Fixes missing reference to vnode on initial bind

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 30, 2017

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Aug 30, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 30, 2017

Codecov Report

Merging #967 into dev will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #967      +/-   ##
==========================================
+ Coverage   37.44%   37.51%   +0.06%     
==========================================
  Files         101      101              
  Lines        2876     2871       -5     
  Branches      859      858       -1     
==========================================
  Hits         1077     1077              
+ Misses       1512     1508       -4     
+ Partials      287      286       -1
Impacted Files Coverage Δ
lib/directives/scrollspy.js 10.54% <0%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e403225...cdb728f. Read the comment docs.

@tmorehouse tmorehouse merged commit 5c35e07 into dev Aug 30, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the fix/963 branch Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment