New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip+popover components): Delay instantiation on mounted() #969

Merged
merged 4 commits into from Aug 30, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 30, 2017

Instantiates tooltip/popover on this.$nextTick(..) to help ensure trigger element and component are in dom.

Should address issue #968

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 30, 2017

@tmorehouse tmorehouse requested review from pi0, alexsasharegan and mosinve Aug 30, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 30, 2017

Codecov Report

Merging #969 into dev will decrease coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #969      +/-   ##
==========================================
- Coverage   37.44%   37.26%   -0.19%     
==========================================
  Files         101      101              
  Lines        2876     2890      +14     
  Branches      859      859              
==========================================
  Hits         1077     1077              
- Misses       1512     1526      +14     
  Partials      287      287
Impacted Files Coverage Δ
lib/components/popover.vue 15.62% <0%> (-1.62%) ⬇️
lib/components/tooltip.vue 19.23% <0%> (-3.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e403225...50a5ece. Read the comment docs.

tmorehouse added some commits Aug 30, 2017

@tmorehouse tmorehouse merged commit 4fc18ec into dev Aug 30, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the fix/968 branch Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment