New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip+popover components): Emit events and minor adjustments #972

Merged
merged 14 commits into from Aug 31, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Aug 30, 2017

No description provided.

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 30, 2017

@tmorehouse tmorehouse requested a review from pi0 Aug 30, 2017

tmorehouse added some commits Aug 30, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Aug 31, 2017

Codecov Report

Merging #972 into dev will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #972      +/-   ##
==========================================
+ Coverage   37.33%   37.36%   +0.03%     
==========================================
  Files         101      101              
  Lines        2885     2882       -3     
  Branches      858      862       +4     
==========================================
  Hits         1077     1077              
+ Misses       1522     1519       -3     
  Partials      286      286
Impacted Files Coverage Δ
lib/components/tooltip.vue 20% <0%> (+0.76%) ⬆️
lib/classes/tooltip.js 5.36% <0%> (ø) ⬆️
lib/components/popover.vue 15.87% <0%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da45a3e...f15291c. Read the comment docs.

tmorehouse added some commits Aug 31, 2017

@tmorehouse tmorehouse changed the title from fix(tooltip+popover components): Minor adjustments to code to fix(tooltip+popover components): Emit events and minor adjustments Aug 31, 2017

@tmorehouse tmorehouse merged commit cf7c538 into dev Aug 31, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse/popovers branch Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment