New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip+popover): Allow element and component reference for target #980

Merged
merged 8 commits into from Sep 1, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Sep 1, 2017

For component version of tooltip and popover, allow target to be given as an element or component reference, besides a string ID.

Deprecates the target-id prop

tmorehouse added some commits Sep 1, 2017

popover.vue] Allow trget to be an element or component reference
Deprecate target ID in favor of target
[toolip/vue] Allow target to b an element or component reference
Deprecates `target-id` prop in favor of `target`

@tmorehouse tmorehouse added this to the v1.0.0 milestone Sep 1, 2017

@tmorehouse tmorehouse requested a review from pi0 Sep 1, 2017

tmorehouse added some commits Sep 1, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Sep 1, 2017

Codecov Report

Merging #980 into dev will decrease coverage by 0.34%.
The diff coverage is 21.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #980      +/-   ##
==========================================
- Coverage   36.78%   36.43%   -0.35%     
==========================================
  Files         102      102              
  Lines        2958     2986      +28     
  Branches      883      891       +8     
==========================================
  Hits         1088     1088              
- Misses       1576     1604      +28     
  Partials      294      294
Impacted Files Coverage Δ
lib/components/popover.vue 13.51% <14.28%> (-2.36%) ⬇️
lib/components/tooltip.vue 14.92% <27.77%> (-5.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 099b1b6...e948f37. Read the comment docs.

@tmorehouse tmorehouse merged commit 8785066 into dev Sep 1, 2017

2 checks passed

License Compliance License checks passed.
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse/toolpops branch Sep 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment