New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip+popover): Add container prop to component versions #983

Merged
merged 10 commits into from Sep 2, 2017

Conversation

Projects
None yet
2 participants
@tmorehouse
Member

tmorehouse commented Sep 2, 2017

Adds a new container prop to the component version of tooltip and popover, to all user to specify which container to append tooltip/popover to.

Container is specified as an element ID string. if not specified (null), then body is used (default)

tmorehouse added some commits Sep 1, 2017

@tmorehouse tmorehouse added this to the v1.0.0 milestone Sep 2, 2017

@tmorehouse tmorehouse requested review from pi0 and alexsasharegan Sep 2, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Sep 2, 2017

Codecov Report

Merging #983 into dev will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #983      +/-   ##
==========================================
- Coverage   36.41%   36.36%   -0.05%     
==========================================
  Files         102      102              
  Lines        2988     2992       +4     
  Branches      892      894       +2     
==========================================
  Hits         1088     1088              
- Misses       1605     1609       +4     
  Partials      295      295
Impacted Files Coverage Δ
lib/components/popover.vue 13.51% <ø> (-0.38%) ⬇️
lib/components/tooltip.vue 14.92% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 472fa79...612f185. Read the comment docs.

tmorehouse added some commits Sep 2, 2017

@tmorehouse tmorehouse merged commit 860cb3c into dev Sep 2, 2017

1 of 2 checks passed

License Compliance FOSSA analyzing commit
Details
ci/circleci Your tests passed on CircleCI!
Details

@tmorehouse tmorehouse deleted the tmorehouse/poptips branch Sep 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment