Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run blocking update #2

Merged
merged 16 commits into from Feb 4, 2020
Merged

Run blocking update #2

merged 16 commits into from Feb 4, 2020

Conversation

@bootstraponline
Copy link
Owner

bootstraponline commented Feb 1, 2020

No description provided.

// runblockingTests
//
// Created by Janek Góral on 31/01/2020.
// Copyright © 2020 gogoapps. All rights reserved.

This comment has been minimized.

Copy link
@bootstraponline

bootstraponline Feb 1, 2020

Author Owner

Let's remove the default comments from Xcode.

This comment has been minimized.

Copy link
@jan-gogo

jan-gogo Feb 3, 2020

Contributor

Ok, I'll do it.

:script => <<-SCRIPT
set -ev
REPO_ROOT="$PODS_TARGET_SRCROOT"
"$REPO_ROOT/../gradlew" -p "$REPO_ROOT" :common:syncFramework \

This comment has been minimized.

Copy link
@bootstraponline

bootstraponline Feb 1, 2020

Author Owner

We intentionally don't use Cocoapods because it's slow and introduces a Ruby dependency. Here's an example of accomplishing the same task with an Xcode shell script:

This comment has been minimized.

Copy link
@jan-gogo

jan-gogo Feb 3, 2020

Contributor

Thanks for review, I'll implement fix ASAP.

@bootstraponline

This comment has been minimized.

Copy link
Owner Author

bootstraponline commented Feb 1, 2020

@jan-gogo I left some comments. Nice work on the project so far. The example apps are helpful for testing.

jan-gogo added 4 commits Feb 3, 2020
Freezes anyway as described here ktorio/ktor#678 (comment)

* Upgrade kotlin coroutines to 1.3.3
* Remove default comments from iOS sources
* Fix package name clash between common and android
* rename common to CommonRunBlocking (due to some errors with accessing native code)
* add simplified packForXcode script
into(targetDir)
}

tasks.getByName("build").dependsOn(packForXcode)

This comment has been minimized.

Copy link
@bootstraponline

bootstraponline Feb 4, 2020

Author Owner

image

Small comment, it's good to end with a newline. 🙂

This comment has been minimized.

Copy link
@jan-gogo

jan-gogo Feb 4, 2020

Contributor

Right. Small thing, I forgot about that. Fixed

@bootstraponline bootstraponline merged commit 7ad1845 into bootstraponline:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.