Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master with better droptargets #213

Merged
merged 7 commits into from Mar 4, 2019
Merged

Conversation

justinpombrio
Copy link
Collaborator

No description provided.

Also add a brief overview of how them use it in the docs.
…and `DropTarget`.

This also fixes a mostly unrelated issue where ctrl-enter broke.
…eem to work OK when it's gone so... I guess it isn't needed?
src/components/DropTarget.jsx Outdated Show resolved Hide resolved
src/components/DropTarget.jsx Outdated Show resolved Hide resolved
src/components/DropTarget.jsx Outdated Show resolved Hide resolved
src/components/DropTarget.jsx Outdated Show resolved Hide resolved
src/components/DropTarget.jsx Show resolved Hide resolved
@schanzer schanzer temporarily deployed to codemirror-blocks-pr-213 March 2, 2019 18:15 Inactive
isEditable: this.state.editableDropTargets,
setEditable: this.setEditable,
}}>
{this.props.children}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'children' is missing in props validation react/prop-types

@pcardune pcardune requested a deployment to codemirror-blocks-pr-213 March 4, 2019 18:42 Abandoned
@justinpombrio justinpombrio merged commit b48b4de into master Mar 4, 2019
@justinpombrio justinpombrio deleted the master-with-better-droptargets branch March 4, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants