Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Restore default mark index after transition start.
Transitions with panels changing visibility still doesn't work quite right,
though. When a panel exits, we currently override the panel instance using the
exit prototype, but don't override all of the children accordingly.
  • Loading branch information
Mike Bostock committed Jun 13, 2010
1 parent 9888653 commit fd9f7e8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/mark/Transition.js
Expand Up @@ -167,12 +167,13 @@ pv.Transition = function(mark) {
mark.$transition = that;

// TODO clearing the scene like this forces total re-build
var before = mark.scene, after;
var i = pv.Mark.prototype.index, before = mark.scene, after;
mark.scene = null;
mark.bind();
mark.build();
after = mark.scene;
mark.scene = before;
pv.Mark.prototype.index = i;

var start = Date.now(), list = {};
interpolate(list, before, after);
Expand Down

0 comments on commit fd9f7e8

Please sign in to comment.