New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: borg list: guaranteed hashes #2123

Closed
enkore opened this Issue Feb 4, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@enkore
Contributor

enkore commented Feb 4, 2017

hashlib.algorithms_guaranteed was expanded with Python 3.6, so we should keep in mind to build the docs with 3.4, since that is our baseline.

@@ -84,14 +84,22 @@ The following keys are available for --format:
  - isomtime
  - isoctime
  - isoatime
 
+ - blake2b
+ - blake2s
  - md5
  - sha1
  - sha224
  - sha256
  - sha384
+ - sha3_224
+ - sha3_256
+ - sha3_384
+ - sha3_512
  - sha512
+ - shake_128
+ - shake_256
 
  - archiveid
  - archivename
  - extra: prepends {source} with " -> " for soft links and " link to " for hard links

@enkore enkore added the documentation label Feb 4, 2017

@ThomasWaldmann

This comment has been minimized.

Show comment
Hide comment
@ThomasWaldmann

ThomasWaldmann Feb 4, 2017

Member

... or document that these are only available on 3.6+.

Member

ThomasWaldmann commented Feb 4, 2017

... or document that these are only available on 3.6+.

@enkore

This comment has been minimized.

Show comment
Hide comment
@enkore

enkore Feb 4, 2017

Contributor

"build the docs" ~ run build_usage... not actually building them. That one doesn't matter.

I think it would be sufficient to just not have them in the official docs. The local --help will tell what's exactly available on the local system.

Contributor

enkore commented Feb 4, 2017

"build the docs" ~ run build_usage... not actually building them. That one doesn't matter.

I think it would be sufficient to just not have them in the official docs. The local --help will tell what's exactly available on the local system.

@ThomasWaldmann

This comment has been minimized.

Show comment
Hide comment
@ThomasWaldmann

ThomasWaldmann Feb 4, 2017

Member

ok, so the real change needed is in the development docs "how to make a release".

Member

ThomasWaldmann commented Feb 4, 2017

ok, so the real change needed is in the development docs "how to make a release".

milkey-mouse added a commit to milkey-mouse/borg that referenced this issue Mar 8, 2017

Add warning about running build_usage on Python >3.4 (fixes borgbacku…
…p#2123)

Python 3.6 added some new guaranteed hashing algorithms that will
show up as available in the docs even though the baseline for support
is Python 3.4; running build_usage with Python 3.4 will fix this.

enkore added a commit to milkey-mouse/borg that referenced this issue Mar 9, 2017

Add warning about running build_usage on Python >3.4 (fixes borgbacku…
…p#2123)

Python 3.6 added some new guaranteed hashing algorithms that will
show up as available in the docs even though the baseline for support
is Python 3.4; running build_usage with Python 3.4 will fix this.

# Conflicts:
#	docs/development.rst

@enkore enkore closed this in 85a2d2f Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment