Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FutureWarning about use_bin_type from msgpack 0.5 #3517

Closed
ThomasWaldmann opened this issue Jan 8, 2018 · 4 comments
Closed

FutureWarning about use_bin_type from msgpack 0.5 #3517

ThomasWaldmann opened this issue Jan 8, 2018 · 4 comments
Assignees
@ThomasWaldmann
Milestone
1.1.5

Comments

@ThomasWaldmann
Copy link
Member

https://travis-ci.org/borgbackup/borg/jobs/326101482

see the complaints about use_bin_type.
@ThomasWaldmann ThomasWaldmann added this to the 1.1.5 milestone Jan 8, 2018
@ThomasWaldmann ThomasWaldmann changed the title more msgpack 0.5 fun FutureWarning about use_bin_type from msgpack 0.5 Jan 9, 2018
@ThomasWaldmann ThomasWaldmann self-assigned this Jan 9, 2018
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Jan 9, 2018
@ThomasWaldmann
msgpack: explicitly give use_bin_type=False, fixes borgbackup#3517
29091d9 
since 0.5.0, msgpack always wants use_bin_type.

if not given, it emits a FutureWarning about the intention to change
the default value later.
@ThomasWaldmann
Copy link
Member Author

this was solved by excluding msgpack 0.5.0.
msgpack 0.5.1 was released and doesn't give the FutureWarning.

@infectormp infectormp mentioned this issue Jan 12, 2018
Closed
@ThomasWaldmann
Copy link
Member Author

5e007ea

distributions could adjust the requirements and packages that way. ^
will be like this in next borg release anyway.

@audeoudh
Copy link
Contributor

I still have this warning, even with recent version of borg (1.1.4) & msgpack (0.5.4).

$ borg info <remote>
Remote: /usr/lib/python3.6/site-packages/msgpack/__init__.py:47: FutureWarning: use_bin_type option is not specified. Default value of the option will be changed in future version.
[…]

@ThomasWaldmann
Copy link
Member Author

ThomasWaldmann commented Feb 23, 2018 •
edited

Use msgpack-python < 0.5.0.
And if that warning still happens on the latest version, file a bug at the msgpack project.

See also #3632.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasWaldmann ThomasWaldmann

Labels
None yet
Projects
None yet
Milestone
1.1.5
Development

No branches or pull requests
2 participants
@ThomasWaldmann @audeoudh