Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl support for NetBSD #433

Closed
ThomasWaldmann opened this issue Nov 19, 2015 · 5 comments
Closed

acl support for NetBSD #433

ThomasWaldmann opened this issue Nov 19, 2015 · 5 comments

Comments

@ThomasWaldmann
Copy link
Member

borgbackup already has ACL support for Linux, FreeBSD and Mac OS X.

It seems like OpenBSD and FreeBSD have acl support, too:
https://github.com/grke/burp/blob/11cd1c9f03e4d19d221d00bcb39c831b23ce57ad/src/client/acl.c

So, is this a missing feature for borgbackup? Anybody using ACLs on OpenBSD or NetBSD?

This needs somebody familiar with these systems to help implementing and testing, so speak up if you want to help!

@anarcat
Copy link
Contributor

anarcat commented Nov 20, 2015

i think this is basically filesystem-specific: we're going to have similar issues with NTFS, HFS (Mac) and so on. one would hope that the acl module we're using would handle all those use-cases, no?

@ThomasWaldmann
Copy link
Member Author

yes, for windows/cygwin there is no acl support either yet.

@enkore
Copy link
Contributor

enkore commented Jul 14, 2016

Solaris and OpenIndiana -> #1337

@enkore
Copy link
Contributor

enkore commented Jul 14, 2016

OpenBSD has no ACL support.

#if defined(HAVE_LINUX_OS) || \
    defined(HAVE_FREEBSD_OS) || \
    defined(HAVE_OPENBSD_OS) || \
    defined(HAVE_NETBSD_OS)
#include "sys/acl.h"

If that's supposed to be a platform header then it won't compile on OpenBSD. There is no such header.

Edit: And indeed, OpenBSD was removed from this list in all instances in Burp in Dec 2015 after a bug report. rubenk/burp@8bcd213

@enkore enkore changed the title acl support for openbsd, netbsd acl support for NetBSD Jul 16, 2016
@enkore
Copy link
Contributor

enkore commented Jul 18, 2016

NetBSD IMHO supports no ACLs at this time. It has the FreeBSD syscalls in the fbsd compat layer (so code using these runs, but doesn't do anything), but these are not implemented (ENOSYS).

@enkore enkore closed this as completed Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants